-
Notifications
You must be signed in to change notification settings - Fork 256
DEVREL-930 Oapp solana migrate lzrt v2 #1850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🚨 E2E Tests FailedThe E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:
This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information. |
🚨 E2E Tests FailedThe E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:
This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information. |
🚨 E2E Tests FailedThe E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:
This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information. |
|
Needs internal review but should not be merged yet. |
DanL0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
please make sure to test on testnet as well to see if automatic delivery is working
one small thing, seems event authority is unused, please fix
examples/oapp-solana/programs/my_oapp/src/instructions/lz_receive_types_v2.rs
Outdated
Show resolved
Hide resolved
🚨 E2E Tests FailedThe E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:
This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information. |
PR SummaryMigrate Solana OApp to V2 execution planning
Generated SDK and types refresh
Tooling and docs
Written by Cursor Bugbot for commit 8b81ec1. This will update automatically on new commits. Configure here. |
🧪 E2E Test StatusE2E tests are non-blocking and validate real blockchain interactions. Failures may occur due to network issues, RPC rate limits, or external service downtime. Test Runs (Newest First):
|
| export type LzReceiveInstructionData = { | ||
| discriminator: Uint8Array | ||
| params: LzReceiveParams | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TypeScript client missing payer account for lzReceive instruction
High Severity
The Rust LzReceive struct was updated to include a new payer: Signer<'info> account at index 0, shifting store to index 1 and peer to index 2. However, the auto-generated TypeScript client for lzReceive was not updated accordingly — it still only has store at index 0 and peer at index 1, completely missing the payer account. While the Executor uses lz_receive_types_v2 to get the correct account list (which does include payer via AddressLocator::Payer), any direct usage of the TypeScript lzReceive function would fail because the account order doesn't match what the program expects.
Changes
Proof of Test
https://testnet.layerzeroscan.com/tx/0x916bcbae88f6bf590f6379ab1ea411e9be4b59813b0437d220c38cca7e588671
https://solscan.io/tx/2NT5MEk97ztZoGJ7UtZv3Byu2tiUuhcLA2oukDvWetHc82wX8QXkB1sa7YvRQSpVe1tsKvqS26JeKxYCfwL3zhcC?cluster=devnet
Notes